[3.8] Enforce strict mypy checks #5425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih. (cherry picked from commit 742a8b6) Co-authored-by: Dmitry Erlikh <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
|
This may need to wait for @greshilov to backport #5408 + #5416 |
webknjaz
approved these changes
Jan 21, 2021
|
OTOH this is probably fine to merge w/o those backports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change covers the entire codebase with strict typings
and makes the ignores granular.
PR #5370 by @derlih.
(cherry picked from commit 742a8b6)
Co-authored-by: Dmitry Erlikh [email protected]
What do these changes do?
mypy strict check
Are there changes in behavior for the user?
no
Related issue number
#3927
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.