http-parser -> llhttp

[derlih]

What do these changes do?

Migrate from http-parser to llhttp

Are there changes in behavior for the user?

No

Related issue number

Closes #3561

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[greshilov]

This PR deserves more attention IMHO. lhttp is an official replacement for the http_parser from nodejs developers.

@derlih Did you perform any benchmarking with this?

[derlih]

No I didn't. I created this PR just because lhttp is a replacement.

[davfsa]

Would like to bump this pr as http-parser is no longer maintained (nodejs/http-parser#522).

@greshilov There are some benchmarks up in llhttp's README (https://github.com/nodejs/llhttp#performance). Hope that is what you were looking for :)

[asvetlov]

LGTM, amazing job!

Let's include it into aiohttp 3.8 and do battle testing.

[patchback]

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d379c6b on top of patchback/backports/3.8/d379c6b81fa32546c75a766e7a02b23851be29c6/pr-5364

Backporting merged PR #5364 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.8/d379c6b81fa32546c75a766e7a02b23851be29c6/pr-5364 upstream/3.8

4. Now, cherry-pick PR http-parser -> llhttp #5364 contents into that branch:

   $ git cherry-pick -x d379c6b81fa32546c75a766e7a02b23851be29c6

   If it'll yell at you with something like fatal: Commit d379c6b81fa32546c75a766e7a02b23851be29c6 is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x d379c6b81fa32546c75a766e7a02b23851be29c6

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR http-parser -> llhttp #5364 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.8/d379c6b81fa32546c75a766e7a02b23851be29c6/pr-5364

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[aio-libs-github-bot]

💔 Backport was not successful

The PR was attempted backported to the following branches:

• ❌ 3.8: Commit could not be cherrypicked due to conflicts

[webknjaz]

@asvetlov looks like this broke the CI: https://github.com/aio-libs/aiohttp/runs/4022543435?check_suite_focus=true

[asvetlov]

I see :(
#6143 reverts the commit, we need to investigate/fix tests first

[socketpair]

WOW