Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI link and typo in setup.py #5274

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Fix CI link and typo in setup.py #5274

merged 1 commit into from
Nov 23, 2020

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #5274 (c2fce18) into master (a6c7f15) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5274   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          43       43           
  Lines        8806     8809    +3     
  Branches     1415     1415           
=======================================
+ Hits         8590     8593    +3     
  Misses        101      101           
  Partials      115      115           
Flag Coverage Δ
unit 97.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.39% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c7f15...c2fce18. Read the comment docs.

@asvetlov asvetlov merged commit 1879aa1 into master Nov 23, 2020
@asvetlov asvetlov deleted the setup-py branch November 23, 2020 10:21
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Nov 23, 2020
(cherry picked from commit 1879aa1)

Co-authored-by: Andrew Svetlov <[email protected]>
@@ -100,7 +100,7 @@ def read(f):
url="https://github.com/aio-libs/aiohttp",
project_urls={
"Chat: Gitter": "https://gitter.im/aio-libs/Lobby",
"CI: Azure Pipelines": "https://dev.azure.com/aio-libs/aiohttp/_build",
"CI: GitHub Actions": "https://github.com/aio-libs/aiohttp/actions?query=workflow%3ACI", # noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally add a filter for the master branch, otherwise, it'll also list runs from PR branches that may originate from upstream but aren't ready..

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants