Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Custom error message for Unix connect errors (#4985) #5264

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

asvetlov
Copy link
Member

Co-authored-by: Sviatoslav Sydorenko [email protected]

Co-authored-by: Andrew Svetlov [email protected]

* Custom error message for Unix connect errors

* Update aiohttp/client_exceptions.py

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>.
(cherry picked from commit e19c79e)

Co-authored-by: Zeal Wierslee <[email protected]>
@asvetlov asvetlov requested a review from webknjaz as a code owner November 21, 2020 15:07
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 21, 2020
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #5264 (99663ed) into 3.8 (c7988ad) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #5264      +/-   ##
==========================================
- Coverage   97.53%   97.51%   -0.03%     
==========================================
  Files          44       44              
  Lines        8844     8853       +9     
  Branches     1426     1426              
==========================================
+ Hits         8626     8633       +7     
- Misses        102      104       +2     
  Partials      116      116              
Flag Coverage Δ
unit 97.33% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_exceptions.py 98.50% <77.77%> (-1.50%) ⬇️
aiohttp/connector.py 96.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7988ad...99663ed. Read the comment docs.

@asvetlov asvetlov merged commit e55174a into 3.8 Nov 21, 2020
@asvetlov asvetlov deleted the backport-e19c79e-3.8 branch November 21, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants