-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build win 32bit wheel #5234
Build win 32bit wheel #5234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5234 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 8794 8794
Branches 1413 1413
=======================================
Hits 8578 8578
Misses 101 101
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
run: | | ||
make cythonize | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install -U setuptools wheel | ||
- name: Make wheel | ||
run: | ||
run: | | ||
python setup.py bdist_wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's highly discouraged to invoke setuptools directly.
python setup.py bdist_wheel | |
python -m pip wheel -w dist/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(in fact, the today-recommended method is to use python-build front-end for building both source and built dists)
strategy: | ||
matrix: | ||
pyver: [3.6, 3.7, 3.8, 3.9] | ||
os: [macos, windows] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use another matrix entry for arch (with an exclude instruction), just like Andrew did in the repos next door.
What do these changes do?
Build of 32bit Windows wheels in CI
Are there changes in behavior for the user?
No
Related issue number
#5230
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.