Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build win 32bit wheel #5234

Closed
wants to merge 6 commits into from
Closed

Build win 32bit wheel #5234

wants to merge 6 commits into from

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Nov 14, 2020

What do these changes do?

Build of 32bit Windows wheels in CI

Are there changes in behavior for the user?

No

Related issue number

#5230

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@derlih derlih requested a review from webknjaz as a code owner November 14, 2020 16:43
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #5234 (95b312a) into master (a2fef0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5234   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          43       43           
  Lines        8794     8794           
  Branches     1413     1413           
=======================================
  Hits         8578     8578           
  Misses        101      101           
  Partials      115      115           
Flag Coverage Δ
unit 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fef0f...95b312a. Read the comment docs.

@derlih derlih requested a review from asvetlov as a code owner November 14, 2020 17:20
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 14, 2020
@derlih derlih changed the title [WIP] Build win 32bit wheel Build win 32bit wheel Nov 14, 2020
run: |
make cythonize
- name: Install dependencies
run: |
python -m pip install -U setuptools wheel
- name: Make wheel
run:
run: |
python setup.py bdist_wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's highly discouraged to invoke setuptools directly.

Suggested change
python setup.py bdist_wheel
python -m pip wheel -w dist/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in fact, the today-recommended method is to use python-build front-end for building both source and built dists)

strategy:
matrix:
pyver: [3.6, 3.7, 3.8, 3.9]
os: [macos, windows]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use another matrix entry for arch (with an exclude instruction), just like Andrew did in the repos next door.

@derlih derlih closed this Nov 15, 2020
@derlih derlih deleted the win32_wheel branch November 15, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants