Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update close status codes ws #5198

Merged
merged 6 commits into from
Nov 23, 2020

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Nov 3, 2020

What do these changes do?

Add ABNORMAL_CLOSURE and BAD_GATEWAY to WSCloseCode

Are there changes in behavior for the user?

No

Related issue number

Fixes #5192

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #5198 (c292b66) into master (db1a2cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5198   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          43       43           
  Lines        8784     8786    +2     
  Branches     1413     1413           
=======================================
+ Hits         8568     8570    +2     
  Misses        101      101           
  Partials      115      115           
Flag Coverage Δ
unit 97.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/http_websocket.py 98.65% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1a2cd...c292b66. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Eventually we should find a way to support a open range with unknown-yet return codes.

@asvetlov asvetlov merged commit f82f084 into aio-libs:master Nov 23, 2020
@github-actions
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov pushed a commit that referenced this pull request Nov 23, 2020
(cherry picked from commit f82f084)

Co-authored-by: Dmitry Erlikh <[email protected]>
asvetlov added a commit that referenced this pull request Nov 23, 2020
(cherry picked from commit f82f084)

Co-authored-by: Dmitry Erlikh <[email protected]>

Co-authored-by: Dmitry Erlikh <[email protected]>
@derlih derlih deleted the update-close-status-codes-ws branch November 24, 2020 08:58
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing close status codes for websockets
2 participants