-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update close status codes ws #5198
Update close status codes ws #5198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 8784 8786 +2
Branches 1413 1413
=======================================
+ Hits 8568 8570 +2
Misses 101 101
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Eventually we should find a way to support a open range with unknown-yet return codes.
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
(cherry picked from commit f82f084) Co-authored-by: Dmitry Erlikh <[email protected]>
(cherry picked from commit f82f084) Co-authored-by: Dmitry Erlikh <[email protected]> Co-authored-by: Dmitry Erlikh <[email protected]>
What do these changes do?
Add ABNORMAL_CLOSURE and BAD_GATEWAY to WSCloseCode
Are there changes in behavior for the user?
No
Related issue number
Fixes #5192
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.