Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checksum calculation #5183

Merged
merged 14 commits into from
Oct 31, 2020
Merged

Better checksum calculation #5183

merged 14 commits into from
Oct 31, 2020

Conversation

asvetlov
Copy link
Member

  1. Use sha256 instead of md5
  2. Put hashes into .hash directory to avoid working directory pollution.

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #5183 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5183      +/-   ##
==========================================
+ Coverage   97.45%   97.56%   +0.10%     
==========================================
  Files          43       43              
  Lines        8779     8779              
  Branches     1412     1412              
==========================================
+ Hits         8556     8565       +9     
+ Misses        112      100      -12     
- Partials      111      114       +3     
Flag Coverage Δ
unit 97.56% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/helpers.py 96.69% <0.00%> (+0.23%) ⬆️
aiohttp/http_websocket.py 98.64% <0.00%> (+0.27%) ⬆️
aiohttp/http_parser.py 96.69% <0.00%> (+0.88%) ⬆️
aiohttp/http_writer.py 99.12% <0.00%> (+1.75%) ⬆️
aiohttp/frozenlist.py 97.91% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26504e0...1e5f732. Read the comment docs.

@asvetlov asvetlov merged commit c196e8e into master Oct 31, 2020
@asvetlov asvetlov deleted the better-sum branch October 31, 2020 16:37
github-actions bot pushed a commit that referenced this pull request Oct 31, 2020
github-actions bot pushed a commit that referenced this pull request Oct 31, 2020
@github-actions
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

asvetlov added a commit that referenced this pull request Oct 31, 2020
asvetlov added a commit that referenced this pull request Oct 31, 2020
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants