-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace headers #5122
Trace headers #5122
Conversation
Currently there is one problem with the generated documentation. I don't see the link to the source code for class TraceRequestHeadersSentParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please apply the last documentation polishing
FYI. We use squash-and-merge strategy for the project. Sure, but you still can use rebase and force-push if you want but it doesn't make much sense. The history becomes linear on PR merging, not on the stage of working on the PR. |
LGTM, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5122 +/- ##
=======================================
Coverage 97.57% 97.58%
=======================================
Files 43 43
Lines 8825 8844 +19
Branches 1416 1419 +3
=======================================
+ Hits 8611 8630 +19
Misses 100 100
Partials 114 114
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Andrew Svetlov <[email protected]>
What do these changes do?
Add a tracing signal to the client sent headers
Are there changes in behavior for the user?
Yes
Related issue number
#5105
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.