Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Content-Length header for 1xx 204 #5119

Merged
merged 3 commits into from
Oct 24, 2020

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Oct 24, 2020

What do these changes do?

Remove Content-Length header for 1xx or 204 according to rfc7230

Are there changes in behavior for the user?

No

Related issue number

Fixes #4901

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@derlih derlih requested a review from asvetlov as a code owner October 24, 2020 16:18
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #5119 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5119   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          43       43           
  Lines        8824     8824           
  Branches     1415     1415           
=======================================
  Hits         8604     8604           
  Misses        103      103           
  Partials      117      117           
Flag Coverage Δ
#unit 97.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_response.py 97.79% <100.00%> (+<0.01%) ⬆️
aiohttp/helpers.py 96.69% <0.00%> (-0.03%) ⬇️
aiohttp/client_reqrep.py 97.36% <0.00%> (ø)
aiohttp/web.py 97.45% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbd52c...129df48. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@asvetlov asvetlov merged commit db3db67 into aio-libs:master Oct 24, 2020
@asvetlov
Copy link
Member

Thanks!

aio-libs-github-bot bot pushed a commit that referenced this pull request Oct 24, 2020
@aio-libs-github-bot
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

aio-libs-github-bot bot added a commit that referenced this pull request Oct 24, 2020
Backports the following commits to 3.7:
 - No Content-Length header for 1xx 204 (#5119)

Co-authored-by: Dmitry Erlikh <[email protected]>
@derlih derlih deleted the 1xx-204-wrong-headers branch October 24, 2020 18:57
damb pushed a commit to EIDA/eidaws that referenced this pull request May 6, 2021
- The fix was implemented upstream with
  aio-libs/aiohttp#5119.
- Adjust aiohttp version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MUST NOT send Content-Length/Transfer-Encoding for 1xx or 204
3 participants