Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint on BaseRunner.addresses #5086

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Fix type hint on BaseRunner.addresses #5086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0571a4
Fix type hint on BaseRunner.addresses
ported-pw Oct 19, 2020
2028189
Create change file
ported-pw Oct 19, 2020
bc5ef9c
Give the change file the proper name
ported-pw Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/5086.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix type hint on BaseRunner.addresses (from List[str] to List[Any])
4 changes: 2 additions & 2 deletions aiohttp/web_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ def server(self) -> Optional[Server]:
return self._server

@property
def addresses(self) -> List[str]:
ret = [] # type: List[str]
def addresses(self) -> List[Any]:
ret = [] # type: List[Any]
for site in self._sites:
server = site._server
if server is not None:
Expand Down