-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for race condition on connections in BaseConnector #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4937 +/- ##
==========================================
+ Coverage 97.58% 97.61% +0.03%
==========================================
Files 43 43
Lines 8932 8932
Branches 1406 1406
==========================================
+ Hits 8716 8719 +3
+ Misses 96 95 -1
+ Partials 120 118 -2
Continue to review full report at Codecov.
|
psf-chronographer
bot
added
the
bot:chronographer:provided
There is a change note present in this PR
label
Aug 27, 2020
PandaWill
changed the title
Update test to trigger race condition
Fix for race condition on connections in BaseConnector
Aug 27, 2020
asvetlov
approved these changes
Oct 15, 2020
Thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
(cherry picked from commit ad00c2e)
Merged
5 tasks
asvetlov
pushed a commit
that referenced
this pull request
Oct 15, 2020
(cherry picked from commit ad00c2e) Co-authored-by: Will <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Demonstrates & fixes race condition bug reported in #4936
Are there changes in behavior for the user?
None
Related issue number
#4936
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.