Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for race condition on connections in BaseConnector #4937

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

PandaWill
Copy link
Contributor

@PandaWill PandaWill commented Aug 26, 2020

What do these changes do?

Demonstrates & fixes race condition bug reported in #4936

Are there changes in behavior for the user?

None

Related issue number

#4936

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@PandaWill PandaWill requested a review from asvetlov as a code owner August 26, 2020 21:08
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #4937 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4937      +/-   ##
==========================================
+ Coverage   97.58%   97.61%   +0.03%     
==========================================
  Files          43       43              
  Lines        8932     8932              
  Branches     1406     1406              
==========================================
+ Hits         8716     8719       +3     
+ Misses         96       95       -1     
+ Partials      120      118       -2     
Impacted Files Coverage Δ
aiohttp/connector.py 96.44% <100.00%> (+0.16%) ⬆️
aiohttp/web_fileresponse.py 97.82% <0.00%> (-0.55%) ⬇️
aiohttp/pytest_plugin.py 97.51% <0.00%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d296d5...408b5c2. Read the comment docs.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 27, 2020
@PandaWill PandaWill changed the title Update test to trigger race condition Fix for race condition on connections in BaseConnector Aug 27, 2020
@PandaWill PandaWill requested a review from webknjaz as a code owner August 27, 2020 15:24
@asvetlov asvetlov merged commit ad00c2e into aio-libs:master Oct 15, 2020
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants