Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (#4850): Timeouts checked once a second. #4851

Closed
wants to merge 5 commits into from
Closed

Fix (#4850): Timeouts checked once a second. #4851

wants to merge 5 commits into from

Conversation

luckydenis
Copy link

What do these changes do?

Bug fix.

Replaced the ceil method with the round method with rounding to 3 decimal places. This will allow to get a timeout of less than a second.

Are there changes in behavior for the user?

Yes. Now the user can set a timeout of less than a second.

Related issue number

#4850

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 6, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #4851 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4851   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          43       43           
  Lines        8932     8932           
  Branches     1406     1406           
=======================================
  Hits         8718     8718           
  Misses         95       95           
  Partials      119      119           
Impacted Files Coverage Δ
aiohttp/helpers.py 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385b03e...50a00d8. Read the comment docs.

@luckydenis
Copy link
Author

@asvetlov, @webknjaz, Good evening. Apparently, tests were broken in the project (Py38-Cython-Mac, Py38-Cython-Win), according to other queries. I can't reproduce this error on Mac OS.

@asvetlov
Copy link
Member

Superseded by #5091

@asvetlov asvetlov closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants