GunicornWebWorker subclasses can config AppRunner #4720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way to configure the Application Runner created by the `aiohttp.GunicornWebWorker`. This allows `GunicornWebWorker` subclasses to configure its `ApplicationRunner` by introducing the `GunicornWebWorker._get_application_runner_instance` method.
psf-chronographer
bot
added
the
bot:chronographer:provided
This comment has been minimized.
This comment has been minimized.
asvetlov
requested changes
Nov 23, 2020
| @@ -207,6 +201,17 @@ def _get_valid_log_format(self, source_format: str) -> str: | |||
| else: | |||
| return source_format | |||
|
|
|||
| def _get_application_runner_instance(self, app, **kwargs): | |||
There was a problem hiding this comment.
The method should be documented and type hinted.
There was a problem hiding this comment.
How **kwargs are used? I see it is always an empty dict.
|
Our project uses a locally patched workaround. I'd still like to see this accepted so we don't have to carry it, but I'm unable to finish it so I'll close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to configure the Application Runner created by
the
aiohttp.GunicornWebWorker.This allows
GunicornWebWorkersubclasses to configure itsApplicationRunnerby introducing theGunicornWebWorker._get_application_runner_instancemethod.What do these changes do?
This implements Design 1 from this request for comment, comment #2988 (comment)
Are there changes in behavior for the user?
No
Related issue number
#2988
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.