-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6] Bump sphinxcontrib-blockdiag from 1.5.5 to 2.0.0 (#4428) #4576
Conversation
(cherry picked from commit bbea369) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## 3.6 #4576 +/- ##
==========================================
- Coverage 97.96% 97.88% -0.08%
==========================================
Files 44 44
Lines 8886 8886
Branches 1392 1392
==========================================
- Hits 8705 8698 -7
- Misses 72 75 +3
- Partials 109 113 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 3.6 #4576 +/- ##
==========================================
- Coverage 97.96% 97.92% -0.04%
==========================================
Files 44 44
Lines 8886 8886
Branches 1392 1392
==========================================
- Hits 8705 8702 -3
- Misses 72 74 +2
- Partials 109 110 +1
Continue to review full report at Codecov.
|
The Codecov decreases are all around code for Python 3.7. I'm pretty sure that's because the Python 3.7 CI tests all failed due to something about brotlipy, e.g., https://dev.azure.com/aio-libs/aiohttp/_build/results?buildId=2400&view=logs&jobId=0e1435bb-9b02-56e8-f42e-850ecf5364f5&j=0e1435bb-9b02-56e8-f42e-850ecf5364f5&t=04072f5d-ea3c-53d7-c4d2-75ecd591d50d. This might be another transitive bit-rot issue, since this branch hasn't passed CI since October 2019, and the logs for those CI runs have expired. Perhaps backporting #3803 would help, but that hasn't been done for 3.7 either, so it's probably not the right action. Perhaps the Python 3.7 platform doesn't have wheel installed, and we've been lucky before now? https://dev.azure.com/aio-libs/aiohttp/_build/results?buildId=2400&view=logs&j=0e1435bb-9b02-56e8-f42e-850ecf5364f5&t=04072f5d-ea3c-53d7-c4d2-75ecd591d50d&l=56 suggests that installing wheel in the same run doesn't make it available to later packages. |
Right now, brotlipy is trying to run `bdist_wheel`, which fails if wheel is not installed. Observed on the Azure Python 3.7 CI test runner.
Okay, now the Python 3.7 tests are failing, which is progress.
|
(cherry picked from commit 2ef9911) Co-authored-by: Andrew Svetlov <[email protected]>
The failing test was disabled on master in 2ef9911, with the same failure on MacOS that I'm now seeing on all the Python 3.7 builds. So cherry-picking that commit too. |
(cherry picked from commit bbea369)
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Needed to fix CI builds for this branch due to transitive dependency drift, see #4570 (comment)