#454: Don't append CRLF for the last read line #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html says: "NOTE: The CRLF preceding the encapsulation line is considered part of the boundary so that it is possible to have a part that does not end with a CRLF (line break). Body parts that must be considered to end with line breaks, therefore, should have two CRLFs preceding the encapsulation line, the first of which is part of the preceding body part, and the second of which is part of the encapsulation boundary."
|
LGTM! |
|
Thanks! Will wait a bit for @vbraun test report. |
|
+1 works for me! |
asvetlov
added a commit
that referenced
this pull request
Aug 3, 2015
#454: Don't append CRLF for the last read line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html says:
"NOTE: The CRLF preceding the encapsulation line is considered part of
the boundary so that it is possible to have a part that does not end
with a CRLF (line break). Body parts that must be considered to end
with line breaks, therefore, should have two CRLFs preceding
the encapsulation line, the first of which is part of the preceding
body part, and the second of which is part of the encapsulation
boundary."