Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Fix python 3.8 tests under Windows (#4513) #4514

Merged
merged 5 commits into from
Jan 18, 2020
Merged

Conversation

asvetlov
Copy link
Member

No description provided.

* Add Python 3.8 to build matrix

* fix tests

* flake fix

* fixes

* fix mypy

* one more assert

* Move selector_loop fixture to conftest.py

* Add CHANGELOG

* Fix tests on Python 3.8.1

Co-authored-by: hh-h <[email protected]>.
(cherry picked from commit ec493d6)

Co-authored-by: Andrew Svetlov <[email protected]>
@asvetlov asvetlov requested a review from webknjaz as a code owner January 18, 2020 20:16
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 18, 2020
@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #4514 into 3.7 will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.7    #4514      +/-   ##
==========================================
+ Coverage   97.87%   97.93%   +0.05%     
==========================================
  Files          44       44              
  Lines        8911     8945      +34     
  Branches     1395     1406      +11     
==========================================
+ Hits         8722     8760      +38     
+ Misses         79       78       -1     
+ Partials      110      107       -3
Impacted Files Coverage Δ
aiohttp/payload_streamer.py 100% <100%> (ø) ⬆️
aiohttp/tracing.py 100% <0%> (ø) ⬆️
aiohttp/cookiejar.py 100% <0%> (ø) ⬆️
aiohttp/web_request.py 97.52% <0%> (ø) ⬆️
aiohttp/helpers.py 96.5% <0%> (+0.01%) ⬆️
aiohttp/client_reqrep.py 97.48% <0%> (+0.01%) ⬆️
aiohttp/frozenlist.py 97.91% <0%> (+0.04%) ⬆️
aiohttp/pytest_plugin.py 97.57% <0%> (+0.13%) ⬆️
aiohttp/web_response.py 98.2% <0%> (+0.22%) ⬆️
aiohttp/web_fileresponse.py 98.29% <0%> (+0.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0842e82...ccfc090. Read the comment docs.

@asvetlov asvetlov merged commit 68ddbd3 into 3.7 Jan 18, 2020
@asvetlov asvetlov deleted the backport-ec493d6-3.7 branch January 18, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants