Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example #4284

Merged
merged 9 commits into from
Oct 28, 2019
Merged

Fix example #4284

merged 9 commits into from
Oct 28, 2019

Conversation

prostomarkeloff
Copy link
Contributor

@prostomarkeloff prostomarkeloff commented Oct 28, 2019

What do these changes do?

Fix example

Are there changes in behavior for the user?

Related issue number

#4283

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
@asvetlov
Copy link
Member

Thanks for raising a question.
I think we should go in the rather opposite direction: please drop the unused loop parameter from FakeFacebook constructor and other places.

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #4284 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4284      +/-   ##
==========================================
+ Coverage   97.56%   97.57%   +0.01%     
==========================================
  Files          43       43              
  Lines        8855     8855              
  Branches     1385     1385              
==========================================
+ Hits         8639     8640       +1     
+ Misses         93       92       -1     
  Partials      123      123
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 98.29% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d3244...e5e0bd7. Read the comment docs.

@prostomarkeloff
Copy link
Contributor Author

prostomarkeloff commented Oct 28, 2019

I think it ready for merge

@asvetlov asvetlov merged commit 8036edc into aio-libs:master Oct 28, 2019
@asvetlov
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants