-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example #4284
Fix example #4284
Conversation
Thanks for raising a question. |
Codecov Report
@@ Coverage Diff @@
## master #4284 +/- ##
==========================================
+ Coverage 97.56% 97.57% +0.01%
==========================================
Files 43 43
Lines 8855 8855
Branches 1385 1385
==========================================
+ Hits 8639 8640 +1
+ Misses 93 92 -1
Partials 123 123
Continue to review full report at Codecov.
|
I think it ready for merge |
thanks! |
What do these changes do?
Fix example
Are there changes in behavior for the user?
Related issue number
#4283
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.