Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Change] Correcting comment in the test file conftest.py #4180

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[Minor Change] Correcting comment in the test file conftest.py #4180

merged 1 commit into from
Oct 14, 2019

Conversation

Maltemo
Copy link
Contributor

@Maltemo Maltemo commented Oct 13, 2019

What do these changes do?

No change to the code, only correcting a comment.

Are there changes in behavior for the user?

No

Related issue number

None

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@Maltemo Maltemo requested a review from asvetlov as a code owner October 13, 2019 20:15
@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #4180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4180   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          43       43           
  Lines        8825     8825           
  Branches     1381     1381           
=======================================
  Hits         8616     8616           
  Misses         88       88           
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d8af7...4e3db86. Read the comment docs.

@asvetlov asvetlov merged commit 36e8a95 into aio-libs:master Oct 14, 2019
@asvetlov
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants