Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Update docs to clarify proxy support (#4101) #4110

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

asvetlov
Copy link
Member

Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via https:// - #4100 .

* Update docs to clarify proxy support

Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 .

* Create 1400.doc

Record change

* Update docs/client_advanced.rst

Differentiate types of HTTP proxies.

Co-Authored-By: Andrew Svetlov <[email protected]>
(cherry picked from commit be95c61)

Co-authored-by: Benjamin Kane <[email protected]>
@asvetlov asvetlov requested a review from webknjaz as a code owner September 27, 2019 06:34
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 27, 2019
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #4110 into 3.6 will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             3.6    #4110      +/-   ##
=========================================
- Coverage   98.1%   98.06%   -0.05%     
=========================================
  Files         44       44              
  Lines       8867     8867              
  Branches    1391     1391              
=========================================
- Hits        8699     8695       -4     
- Misses        63       66       +3     
- Partials     105      106       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️
aiohttp/connector.py 97.43% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c839f...9a3329f. Read the comment docs.

@asvetlov asvetlov merged commit 8f039dc into 3.6 Sep 27, 2019
@asvetlov asvetlov deleted the backport-be95c61-3.6 branch September 27, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants