Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated timeouts in ClientSession constructor #3891

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Drop deprecated timeouts in ClientSession constructor #3891

merged 2 commits into from
Jul 11, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Jul 5, 2019

What do these changes do?

Drop deprecated arguments read_timeout and conn_timeout in ClientSession constructor.

Are there changes in behavior for the user?

no more arguments read_timeout and conn_timeout in ClientSession constructor.

Related issue number

closes #3890

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@atemate atemate requested review from asvetlov and webknjaz as code owners July 5, 2019 17:32
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #3891 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3891     +/-   ##
=========================================
- Coverage   97.81%   97.72%   -0.1%     
=========================================
  Files          43       43             
  Lines        8666     8666             
  Branches     1386     1386             
=========================================
- Hits         8477     8469      -8     
- Misses         82       89      +7     
- Partials      107      108      +1
Impacted Files Coverage Δ
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️
aiohttp/streams.py 97.92% <0%> (-0.52%) ⬇️
aiohttp/helpers.py 96.95% <0%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb01ce...ea545cb. Read the comment docs.

@asvetlov asvetlov merged commit 8311e53 into aio-libs:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop deprecated timeouts in ClientSession constructor
4 participants