-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests_require: add trustme #3518
Conversation
It is required since aio-libs#3487.
I've missed this. |
Codecov Report
@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
- Coverage 97.92% 97.54% -0.38%
==========================================
Files 44 44
Lines 8562 8561 -1
Branches 1381 1380 -1
==========================================
- Hits 8384 8351 -33
- Misses 72 101 +29
- Partials 106 109 +3
Continue to review full report at Codecov.
|
I do. And as long as Actually, there are more missing: pytest-mock, pytest-cov trustme and brotlipy. |
@dotlambda the thing is that using this mechanism is discouraged, we don't really use it and should probably just remove that completely. |
@webknjaz agree |
No, we don't use that at all. But we should probably consider it a breaking change for ones who use it so not backport. Maybe a deprecation warning though. |
I don't have a problem with removing it. |
Our CI is broken now. |
#3752 drops |
It is required since #3487.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.