Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests_require: add trustme #3518

Closed
wants to merge 1 commit into from
Closed

Conversation

dotlambda
Copy link
Contributor

It is required since #3487.

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@asvetlov
Copy link
Member

I've missed this.
How do you use test_require? Do you run python setup.py test?

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #3518 into master will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
- Coverage   97.92%   97.54%   -0.38%     
==========================================
  Files          44       44              
  Lines        8562     8561       -1     
  Branches     1381     1380       -1     
==========================================
- Hits         8384     8351      -33     
- Misses         72      101      +29     
- Partials      106      109       +3
Impacted Files Coverage Δ
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/http_parser.py 93.11% <0%> (-4.82%) ⬇️
aiohttp/http_writer.py 95.28% <0%> (-2.84%) ⬇️
aiohttp/frozenlist.py 97.87% <0%> (-2.13%) ⬇️
aiohttp/helpers.py 95.98% <0%> (-0.76%) ⬇️
aiohttp/test_utils.py 99.03% <0%> (-0.33%) ⬇️
aiohttp/streams.py 98.46% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86af67...c5693e7. Read the comment docs.

@dotlambda
Copy link
Contributor Author

How do you use test_require? Do you run python setup.py test?

I do. And as long as tests_require is specified, it should be complete.

Actually, there are more missing: pytest-mock, pytest-cov trustme and brotlipy.

@webknjaz
Copy link
Member

@dotlambda the thing is that using this mechanism is discouraged, we don't really use it and should probably just remove that completely.

@asvetlov
Copy link
Member

@webknjaz agree
We need either use test_requires in our Travis CI or drop this facility.
I'm inclining to removal.

@webknjaz
Copy link
Member

No, we don't use that at all. But we should probably consider it a breaking change for ones who use it so not backport. Maybe a deprecation warning though.

@dotlambda
Copy link
Contributor Author

I don't have a problem with removing it.

@asvetlov
Copy link
Member

Our CI is broken now.
Please keep the PR open as the reminder.
I'll close the PR after preparing a new one for dropping python setup.py test command.

@asvetlov
Copy link
Member

#3752 drops setup.py test support

@asvetlov asvetlov closed this May 10, 2019
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants