Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] plain text http responses to errors (#3483) #3499

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 8, 2019

(cherry picked from commit b42a23b) ref #3483

Co-authored-by: Samuel Colvin [email protected]

(cherry picked from commit b42a23b)

Co-authored-by: Samuel Colvin <[email protected]>
@asvetlov asvetlov mentioned this pull request Jan 8, 2019
5 tasks
@@ -0,0 +1 @@
Internal Server Errors in plain text if the browser does not support HTML.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the filename here to this pr?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
I'll run towncrier on making 3.5.2 release.
It will delete change files and update the root CHANGES.rst.
After that I'll merge 3.5 branch into master, it will delete CHANGES/3483.feature in master as well.

@asvetlov asvetlov merged commit 396ec1f into 3.5 Jan 8, 2019
@asvetlov asvetlov deleted the backport-b42a23b-3.5 branch January 8, 2019 07:20
@lock
Copy link

lock bot commented Jan 8, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants