Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Fix handling of chunked+gzipped response when first chunk does … #3488

Merged
merged 1 commit into from
Jan 5, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 5, 2019

…not give uncompressed data (#3477) (#3485)

(cherry picked from commit a929c06)

Co-authored-by: Коренберг Марк [email protected]

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

…not give uncompressed data (#3477) (#3485)

(cherry picked from commit a929c06)

Co-authored-by: Коренберг Марк <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #3488 into 3.5 will decrease coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.5    #3488      +/-   ##
==========================================
- Coverage   97.95%   97.93%   -0.03%     
==========================================
  Files          44       44              
  Lines        8553     8557       +4     
  Branches     1377     1378       +1     
==========================================
+ Hits         8378     8380       +2     
- Misses         71       72       +1     
- Partials      104      105       +1
Impacted Files Coverage Δ
aiohttp/streams.py 98.72% <80%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7e642...7b0a5e9. Read the comment docs.

@asvetlov asvetlov merged commit e120033 into 3.5 Jan 5, 2019
@asvetlov asvetlov deleted the backport-a929c06-3.5 branch January 5, 2019 14:49
@lock
Copy link

lock bot commented Jan 5, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 5, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants