Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate debug argument #3381

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Deprecate debug argument #3381

merged 4 commits into from
Nov 5, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 5, 2018

No description provided.

@asvetlov asvetlov requested a review from webknjaz as a code owner November 5, 2018 13:11
@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #3381 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
- Coverage   97.99%   97.96%   -0.04%     
==========================================
  Files          44       44              
  Lines        8486     8489       +3     
  Branches     1375     1376       +1     
==========================================
  Hits         8316     8316              
- Misses         72       74       +2     
- Partials       98       99       +1
Impacted Files Coverage Δ
aiohttp/web_app.py 96.15% <100%> (+0.04%) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.28% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8743741...9734ca7. Read the comment docs.

@asvetlov asvetlov merged commit c96c9af into master Nov 5, 2018
@asvetlov asvetlov deleted the deprecate-debug branch November 5, 2018 22:54
@lock
Copy link

lock bot commented Nov 5, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Nov 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants