Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3194 #3352

Merged
merged 2 commits into from
Oct 21, 2018
Merged

Revert #3194 #3352

merged 2 commits into from
Oct 21, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 21, 2018

Fixes #3350

@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #3352 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
- Coverage   98.05%   98.03%   -0.03%     
==========================================
  Files          44       44              
  Lines        8345     8332      -13     
  Branches     1369     1369              
==========================================
- Hits         8183     8168      -15     
- Misses         67       68       +1     
- Partials       95       96       +1
Impacted Files Coverage Δ
aiohttp/web_app.py 96.09% <100%> (+0.16%) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.49% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1778189...9029bf2. Read the comment docs.

@asvetlov asvetlov merged commit 51371e9 into master Oct 21, 2018
@asvetlov asvetlov deleted the revert-3191 branch October 21, 2018 17:22
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor cleanup_ctx implementation
3 participants