Deprecated use of boolean in resp.enable_compression()

.travis.yml

@@ -180,6 +180,14 @@ jobs:
     script:
     - python setup.py check --metadata --restructuredtext --strict --verbose
 
+  - <<: *_lint_base
+    name:
+    - CONTRIBUTORS.txt sorting check
+    install:
+    - skip
+    script:
+    - LC_ALL=C sort -c CONTRIBUTORS.txt
+
   - <<: *osx_python_base
     python: 3.5.3
     env:

CHANGES/3267.feature

@@ -0,0 +1,2 @@
+Don't raise a warning if ``NETRC`` environment variable is not set and ``~/.netrc`` file
+doesn't exist.

CHANGES/3318.removal

@@ -0,0 +1 @@
+Deprecated use of boolean in ``resp.enable_compression()``

CHANGES/3337.bugfix

@@ -0,0 +1 @@
+Fix tests/test_connector.py typo and tests/autobahn/server.py duplicate loop def.

CHANGES/3341.misc

@@ -0,0 +1 @@
+Added a `lru_cache` to the `parse_mimetype` method

CONTRIBUTORS.txt

@@ -1,5 +1,5 @@
-Contributors
-------------
+- Contributors -
+----------------
 A. Jesse Jiryu Davis
 Adam Mills
 Adrián Chaves
@@ -45,14 +45,14 @@ Brian Muller
 Bryce Drennan
 Carl George
 Cecile Tonglet
-Colin Dunklau
 Chien-Wei Huang
 Chih-Yuan Chen
 Chris AtLee
 Chris Laws
 Chris Moore
 Christopher Schmitt
 Claudiu Popa
+Colin Dunklau
 Damien Nadé
 Dan Xu
 Daniel García
@@ -64,12 +64,12 @@ Denilson Amorim
 Denis Matiychuk
 Dima Veselov
 Dimitar Dimitrov
+Dmitriy Safonov
 Dmitry Doroshev
 Dmitry Lukashin
 Dmitry Shamov
 Dmitry Trofimov
 Dmytro Kuznetsov
-Dmitriy Safonov
 Dustin J. Mitchell
 Eduard Iskandarov
 Eli Ribble
@@ -88,9 +88,9 @@ Gennady Andreyev
 Georges Dubus
 Greg Holt
 Gregory Haynes
-Günther Jena
 Gus Goulart
 Gustavo Carneiro
+Günther Jena
 Hu Bo
 Hugo Herter
 Hynek Schlawack
@@ -126,13 +126,13 @@ Kirill Klenov
 Kirill Malovitsa
 Kyrylo Perevozchikov
 Lars P. Søndergaard
-Loïc Lajeanne
 Louis-Philippe Huberdeau
+Loïc Lajeanne
 Lu Gong
 Lubomir Gelo
 Ludovic Gasc
-Lukasz Marcin Dobrzanski
 Luis Pedrosa
+Lukasz Marcin Dobrzanski
 Makc Belousow
 Manuel Miranda
 Marat Sharafutdinov
@@ -154,6 +154,7 @@ Mun Gwan-gyeong
 Nicolas Braem
 Nikolay Kim
 Nikolay Novik
+Oisin Aylward
 Olaf Conradi
 Pahaz Blinov
 Panagiotis Kolokotronis
@@ -175,9 +176,9 @@ Robert Lu
 Roman Podoliaka
 Samuel Colvin
 Sean Hunt
-Sebastien Geffroy
 Sebastian Hanula
 Sebastian Hüther
+Sebastien Geffroy
 SeongSoo Cho
 Sergey Ninua
 Sergey Skripnick
@@ -198,8 +199,8 @@ Thanos Lefteris
 Thijs Vermeir
 Thomas Forbes
 Thomas Grainger
-Tomasz Trebski
 Tolga Tezel
+Tomasz Trebski
 Trinh Hoang Nhu
 Vadim Suharnikov
 Vaibhav Sagar
@@ -218,12 +219,12 @@ Vladimir Shulyak
 Vladimir Zakharov
 Vladyslav Bondar
 W. Trevor King
+Wei Lin
+Weiwei Wang
 Will McGugan
 Willem de Groot
 William Grzybowski
 Wilson Ong
-Wei Lin
-Weiwei Wang
 Yang Zhou
 Yannick Koechlin
 Yannick Péroux

Makefile

@@ -2,10 +2,8 @@
 
 all: test
 
-install-cython:
+.install-deps: $(shell find requirements -type f)
 	@pip install -r requirements/cython.txt
-
-.install-deps: $(shell find requirements -type f) install-cython
 	@pip install -U -r requirements/dev.txt
 	@touch .install-deps
 
@@ -26,6 +24,9 @@ flake: .flake
             isort --diff -rc aiohttp tests examples; \
             false; \
 	fi
+	@if ! LC_ALL=C sort -c CONTRIBUTORS.txt; then \
+            echo "CONTRIBUTORS.txt sort error"; \
+	fi
 	@touch .flake
 
 check_changes:

aiohttp/base_protocol.py

@@ -10,9 +10,8 @@ class BaseProtocol(asyncio.Protocol):
 
     def __init__(self, loop: Optional[asyncio.AbstractEventLoop]=None) -> None:
         if loop is None:
-            self._loop = asyncio.get_event_loop()
-        else:
-            self._loop = loop
+            loop = asyncio.get_event_loop()
+        self._loop = loop  # type: asyncio.AbstractEventLoop
         self._paused = False
         self._drain_waiter = None  # type: Optional[asyncio.Future[None]]
         self._connection_lost = False

aiohttp/client.py

@@ -99,7 +99,7 @@ def __init__(self, *, connector=None, loop=None, cookies=None,
                  read_timeout=sentinel, conn_timeout=None,
                  timeout=sentinel,
                  auto_decompress=True, trust_env=False,
-                 trace_configs=None):
+                 trace_configs=None) -> None:
 
         implicit_loop = False
         if loop is None:

aiohttp/client_proto.py

@@ -1,4 +1,6 @@
+import asyncio
 from contextlib import suppress
+from typing import Optional
 
 from .base_protocol import BaseProtocol
 from .client_exceptions import (ClientOSError, ClientPayloadError,
@@ -10,7 +12,10 @@
 class ResponseHandler(BaseProtocol, DataQueue):
     """Helper class to adapt between Protocol and StreamReader."""
 
-    def __init__(self, *, loop=None):
+    def __init__(self, *,
+                 loop: Optional[asyncio.AbstractEventLoop]=None) -> None:
+        if loop is None:
+            loop = asyncio.get_event_loop()
         BaseProtocol.__init__(self, loop=loop)
         DataQueue.__init__(self, loop=loop)