Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify timeout in aiohttp.request #3213

Merged
merged 3 commits into from
Aug 31, 2018

Conversation

knight42
Copy link
Contributor

What do these changes do?

Enable users to set ClientTimeout in aiohttp.request

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #3213 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
- Coverage   98.11%   98.07%   -0.04%     
==========================================
  Files          43       43              
  Lines        7853     7853              
  Branches     1354     1354              
==========================================
- Hits         7705     7702       -3     
- Misses         57       59       +2     
- Partials       91       92       +1
Impacted Files Coverage Δ
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b8376...a431e1f. Read the comment docs.

@asvetlov
Copy link
Member

Thank you for the contribution.
Would you reflect the change in aiohttp documentation?

@knight42 knight42 force-pushed the timeout-in-aiohttp-request branch from 70cbfec to f3a0cf9 Compare August 26, 2018 17:43
@knight42
Copy link
Contributor Author

@asvetlov Done!

@knight42
Copy link
Contributor Author

@asvetlov @webknjaz hi! Could this be merged now?

@webknjaz
Copy link
Member

@knight42 could you please also add a changelog fragment to CHANGES folder?

@knight42
Copy link
Contributor Author

@webknjaz Done!

@webknjaz
Copy link
Member

Thanks!

@webknjaz webknjaz merged commit 03d83b0 into aio-libs:master Aug 31, 2018
@knight42 knight42 deleted the timeout-in-aiohttp-request branch August 31, 2018 10:37
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants