Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web.options #3063

Merged
merged 1 commit into from
Jun 9, 2018
Merged

add web.options #3063

merged 1 commit into from
Jun 9, 2018

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jun 8, 2018

What do these changes do?

See #3062

Are there changes in behavior for the user?

web.options is added and web.route(METH_OPTIONS, '/foo/', foo, name='foo') now works

Related issue number

#3062

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes (there's no explicit docs for web.head etc. either)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@samuelcolvin samuelcolvin requested a review from asvetlov June 8, 2018 10:48
@codecov-io
Copy link

Codecov Report

Merging #3063 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
+ Coverage   98.11%   98.11%   +<.01%     
==========================================
  Files          42       42              
  Lines        7743     7747       +4     
  Branches     1349     1349              
==========================================
+ Hits         7597     7601       +4     
  Misses         51       51              
  Partials       95       95
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.11% <100%> (ø) ⬆️
aiohttp/web_routedef.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8831f3...11742a9. Read the comment docs.

@samuelcolvin samuelcolvin changed the title add web.options, add web.options Jun 8, 2018
@asvetlov asvetlov merged commit f26a49d into aio-libs:master Jun 9, 2018
@asvetlov
Copy link
Member

asvetlov commented Jun 9, 2018

Cool! Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants