Do fire DNS tracing events #2858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 39 39
Lines 7444 7444
Branches 1307 1307
=======================================
Hits 7293 7293
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
|
|
||
| await client.get('/redirector', data="foo") | ||
| await client.get('http://example.com/redirector', data="foo") |
There was a problem hiding this comment.
a f"localhost:{server.port}/redirector" does not fire a DNS event? If it does we wouldn't need it the FakeResolver
There was a problem hiding this comment.
Resolver doesn't perform DNS lookup for IP addresses, only for domain names.
localhost should be sufficient but unfortunately there are too many boxes with declared but actually disabled IPv6 support.
There was a problem hiding this comment.
sorry I don't get the following sentence.
there are too many boxes with declared but actually disabled IPv6 support.
There was a problem hiding this comment.
I dont want to block the PR just for a test that in any case can be at any moment refactorized.
There was a problem hiding this comment.
Ok, I'll try to describe. Some broken environments (Travis-CI included IIRC) resolves localhost to both 127.0.0.1 and ::1 but IPv6 stack is disabled.
By this communication over IPv6 ::1 fails.
That's why aiohttp.test_utils and aiohttp test suite use IPv4 127.0.0.1 explicitly.
The situation could be improved I hope but working on it is definitely out if the issue scope.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
Fix for #2841