Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket client should stopped without returning stop marker to user when get an EofStream. #2814

Merged
merged 6 commits into from
Mar 16, 2018

Conversation

thomaszdxsn
Copy link
Contributor

@thomaszdxsn thomaszdxsn commented Mar 8, 2018

…user when get an EofStream.

What do these changes do?

If ClientWebSocketResponse.receive() raise a EofStream, should not return it to user, just stop iteration.

Are there changes in behavior for the user?

use asyn for in ClientWebSocketResponse will not get a EofStream.

Related issue number

#2784

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #2814 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   97.96%   97.97%   +<.01%     
==========================================
  Files          39       39              
  Lines        7426     7445      +19     
  Branches     1305     1307       +2     
==========================================
+ Hits         7275     7294      +19     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.21% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9108698...2d62ac3. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Mar 8, 2018

I suspect server websocket has the same behavior.
Could you take a look?

@thomaszdxsn
Copy link
Contributor Author

ok, i will do that in weekend

@thomaszdxsn
Copy link
Contributor Author

thomaszdxsn commented Mar 13, 2018

Sorry, I don't complete my promise on time.

I not very familiar with aiohttp-server and pytest

@asvetlov
Copy link
Member

NP. Feel free to ask here or use https://gitter.im/aio-libs/Lobby chat.
I'll happy to help (when I'm available online).

@thomaszdxsn
Copy link
Contributor Author

I think it's ok, please review it.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@asvetlov asvetlov merged commit 6027157 into aio-libs:master Mar 16, 2018
@asvetlov
Copy link
Member

Don't want making 3.0.X bugfix release since we are in preparing to 3.1.0.
I expect to get it in a few days.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants