-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix websocket client should stopped without returning stop marker to user when get an EofStream. #2814
Conversation
…user when get an EofStream.
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
+ Coverage 97.96% 97.97% +<.01%
==========================================
Files 39 39
Lines 7426 7445 +19
Branches 1305 1307 +2
==========================================
+ Hits 7275 7294 +19
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
I suspect server websocket has the same behavior. |
ok, i will do that in weekend |
Sorry, I don't complete my promise on time. I not very familiar with aiohttp-server and pytest |
NP. Feel free to ask here or use https://gitter.im/aio-libs/Lobby chat. |
…nstead of WSMsgType.CLOSING
I think it's ok, please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Don't want making 3.0.X bugfix release since we are in preparing to 3.1.0. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
…user when get an EofStream.
What do these changes do?
If
ClientWebSocketResponse.receive()
raise aEofStream
, should not return it to user, just stop iteration.Are there changes in behavior for the user?
use
asyn for
in ClientWebSocketResponse will not get a EofStream.Related issue number
#2784
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.