Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup default loop in test utilities #2804

Merged
merged 5 commits into from
Mar 7, 2018
Merged

Setup default loop in test utilities #2804

merged 5 commits into from
Mar 7, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Mar 6, 2018

The change is safe: minimal supported Python 3.5.3 always returns a running event loop if asyncio.get_event_loop() is called from a coroutine.

Also it is a step for seamless integration with pytest-asyncio: the library installs the loop internally.

@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #2804 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2804   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          39       39           
  Lines        7379     7379           
  Branches     1296     1296           
=======================================
  Hits         7231     7231           
  Misses         47       47           
  Partials      101      101
Impacted Files Coverage Δ
aiohttp/pytest_plugin.py 98.62% <100%> (ø) ⬆️
aiohttp/test_utils.py 98.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20928e1...6632efe. Read the comment docs.

@asvetlov asvetlov merged commit 5853890 into master Mar 7, 2018
@asvetlov asvetlov deleted the default-loop branch March 7, 2018 07:23
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants