Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per message deflate #2583

Merged
merged 10 commits into from
Dec 2, 2017
Merged

Per message deflate #2583

merged 10 commits into from
Dec 2, 2017

Conversation

azhpushkin
Copy link
Contributor

@azhpushkin azhpushkin commented Dec 1, 2017

What do these changes do?

This PR allows to pass optional argument compress to send_str, send_bytes and sent_json methods of ClientWebSocketResponse and WebSocketResponse.

Are there changes in behavior for the user?

Argument is optional and default behavior (compress=None) did not changed so older code is not affected.

Related issue number

Resolves #2551

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder

@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #2583 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
+ Coverage   97.71%   97.71%   +<.01%     
==========================================
  Files          36       36              
  Lines        7226     7229       +3     
  Branches     1261     1262       +1     
==========================================
+ Hits         7061     7064       +3     
  Misses         58       58              
  Partials      107      107
Impacted Files Coverage Δ
aiohttp/http_websocket.py 98.61% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d166230...5529e76. Read the comment docs.

@asvetlov asvetlov merged commit 6a1e71c into aio-libs:master Dec 2, 2017
@asvetlov
Copy link
Member

asvetlov commented Dec 2, 2017

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Per message deflate configurable per message
3 participants