Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Per message deflate configurable per message #2551

Closed
FlorianLudwig opened this issue Nov 24, 2017 · 6 comments · Fixed by #2583
Closed

Feature Request: Per message deflate configurable per message #2551

FlorianLudwig opened this issue Nov 24, 2017 · 6 comments · Fixed by #2583
Labels

Comments

@FlorianLudwig
Copy link

Long story short

It is called "per message compression" but is not configurable per message.

Suggested API change:

coroutine send_str(data, compress=None)

The compress argument allows to overwrite the value from WebSocketResponse on a per message basis.

Same for send_bytes and send_json

@asvetlov
Copy link
Member

asvetlov commented Nov 24, 2017

I like the proposal.
Would you work on Pull Request?

@FlorianLudwig
Copy link
Author

@asvetlov I love to get into the inner workings of aiohttp but as of right now I don't have the time at hand.

So at same later time I will :)

@azhpushkin
Copy link
Contributor

@FlorianLudwig @asvetlov I would like to take on PR for this feature, do you mind it?

@asvetlov
Copy link
Member

asvetlov commented Dec 1, 2017

Please do

@FlorianLudwig
Copy link
Author

@maqquettex awesome, thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants