StreamResponse and Response implement MutableMapping interface

[argaen]

What do these changes do?

StreamResponse and Response are not MutableMappings

Are there changes in behavior for the user?

Now users can store data in the response object like response['data'] = whatever

Related issue number

#2246

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov-io]

Codecov Report

Merging #2494 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
+ Coverage   97.08%   97.09%   +<.01%     
==========================================
  Files          40       40              
  Lines        8141     8153      +12     
  Branches     1439     1439              
==========================================
+ Hits         7904     7916      +12     
  Misses        100      100              
  Partials      137      137

Impacted Files	Coverage Δ
aiohttp/web_response.py	98.25% <100%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67eb1e7...9bd12b3. Read the comment docs.

[asvetlov]

Drop state from accepted parameters.
Otherwise you should support it in all derived response classes like web.Response.
I think the second is pointless and don't worth a new param,

[asvetlov]

@argaen ping

[argaen]

Oops, will submit changes today :)

[argaen]

updated

[asvetlov]

Please add a couple sentences to web_reference.rst like we already have for Application: https://docs.aiohttp.org/en/latest/web_reference.html#application (Application is a dict-like object, ....)

[argaen]

Added, copied what was describe for Request object

[asvetlov]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new