Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template release branch docs to reflect current version #2463

Merged
merged 1 commit into from
Nov 4, 2017

Conversation

zackhsi
Copy link
Contributor

@zackhsi zackhsi commented Nov 4, 2017

0.xx -> x.x.x, no longer version 0 :)

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@zackhsi zackhsi changed the title Update feature branch to reflect current versions Update PR template release branch docs to reflect current version Nov 4, 2017
@codecov-io
Copy link

codecov-io commented Nov 4, 2017

Codecov Report

Merging #2463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2463   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          39       39           
  Lines        8127     8127           
  Branches     1419     1419           
=======================================
  Hits         7895     7895           
  Misses        101      101           
  Partials      131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340efbb...dd51e4b. Read the comment docs.

@kxepal kxepal merged commit 3e6bc93 into aio-libs:master Nov 4, 2017
@kxepal
Copy link
Member

kxepal commented Nov 4, 2017

Nice find! Thanks!

the latest release branch (which looks like "0.xx") -->
- If this is a bug fix or documentation amendment, select the latest
[release branch](https://github.com/aio-libs/aiohttp/branches) (which
looks like "x.x.x") -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X.x actualy, like 2.
x.x.x is for release tag like v2.3.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 94656c0 - I expected it will create PR, but commit happened, sorry /:

@asvetlov
Copy link
Member

asvetlov commented Nov 4, 2017

N.P.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants