Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed ValueError for AF_INET6 sockets #2431

Merged
merged 4 commits into from
Oct 30, 2017
Merged

fixed ValueError for AF_INET6 sockets #2431

merged 4 commits into from
Oct 30, 2017

Conversation

ffix
Copy link
Contributor

@ffix ffix commented Oct 29, 2017 •
edited
Loading

What do these changes do?

There is an issue if you pass a preexisting INET6 socket to the aiohttp.web.run_app function.

Traceback (most recent call last):
  File "test_aiohttp.py", line 26, in <module>
    web.run_app(app, sock=sock1)
  File "/usr/lib/python3.6/site-packages/aiohttp/web.py", line 435, in run_app
    backlog=backlog)
  File "/usr/lib/python3.6/site-packages/aiohttp/web.py", line 407, in _make_server_creators
    host, port = sock.getsockname()
ValueError: too many values to unpack (expected 2)

Are there changes in behavior for the user?

It's a bugfix.

Related issue number

There is no tracked issue.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Oct 29, 2017 •
edited
Loading

Codecov Report

Merging #2431 into 2.3 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2431   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          39       39           
  Lines        8224     8224           
  Branches     1442     1442           
=======================================
  Hits         7997     7997           
  Misses         98       98           
  Partials      129      129
Impacted Files Coverage Δ
aiohttp/web.py 99.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a9162...2f577bb. Read the comment docs.

asvetlov
asvetlov requested changes Oct 29, 2017
View reviewed changes
tests/test_run_app.py Outdated
@@ -42,6 +42,16 @@
)
del _has_unix_domain_socks, _abstract_path_failed

has_ipv6 = socket.has_ipv6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has_ipv6 should be upper-cased: it is a contant

Copy link
Contributor Author

@ffix ffix Oct 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied it from another test module as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please make it upper cased anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

@asvetlov asvetlov merged commit 4cc392f into aio-libs:2.3 Oct 30, 2017
@asvetlov
Copy link
Member

thanks!

adrienverge added a commit to adrienverge/localstripe that referenced this pull request Mar 23, 2018
@adrienverge
chore(deps): Make sure aiohttp >= 2.3.2
cbf62c5 
To avoid this bug on some machines:

    Traceback (most recent call last):
        [...]
        web.run_app(app, sock=sock, access_log=logger)
        [...]
        host, port = sock.getsockname()
    ValueError: too many values to unpack (expected 2)

See a better description at
aio-libs/aiohttp#2431
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffix @codecov-io @asvetlov