Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy from env #2256

Merged
merged 17 commits into from
Sep 19, 2017
Merged

Proxy from env #2256

merged 17 commits into from
Sep 19, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Sep 8, 2017

Proxy environments support

Fix for #1998

@codecov-io
Copy link

codecov-io commented Sep 8, 2017

Codecov Report

Merging #2256 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
- Coverage    97.3%   97.25%   -0.05%     
==========================================
  Files          39       39              
  Lines        8051     8091      +40     
  Branches     1395     1408      +13     
==========================================
+ Hits         7834     7869      +35     
- Misses         94       97       +3     
- Partials      123      125       +2
Impacted Files Coverage Δ
aiohttp/helpers.py 97.43% <100%> (+0.15%) ⬆️
aiohttp/client_reqrep.py 97.33% <100%> (-0.03%) ⬇️
tests/autobahn/client.py 94.5% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23406aa...4897a46. Read the comment docs.

@asvetlov asvetlov changed the title [WIP] Proxy from env Proxy from env Sep 17, 2017
@asvetlov
Copy link
Member Author

Ready for review

@asvetlov asvetlov merged commit 0958dde into master Sep 19, 2017
@asvetlov asvetlov deleted the proxy_from_env branch September 19, 2017 09:08
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants