Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #216: HttpMessage._add_default_headers does not overwrite existing headers #219

Merged
merged 2 commits into from
Jan 2, 2015

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 2, 2015

I have had drop SERVER and DATE from hop-by-hop headers also.
According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html 13.5.1 End-to-end and Hop-by-hop Headers those headers are not in hop-by-hop list.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 2, 2015

+1 for useragent

i'm not sure about server and date, here is reason:

# Server and Date aren't technically hop-by-hop
# headers, but they are in the purview of the
# origin server which the WSGI spec says we should
# act like. So we drop them and add our own.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 2, 2015

+1 for server and date

@kxepal
Copy link
Member

kxepal commented Jan 2, 2015

+1

asvetlov added a commit that referenced this pull request Jan 2, 2015
Fix #216: HttpMessage._add_default_headers does not overwrite existing headers
@asvetlov asvetlov merged commit 26f380b into master Jan 2, 2015
@asvetlov asvetlov deleted the issue_216_dont_override_headers branch January 2, 2015 09:00
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants