Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacklevel in _CoroGuard's warning #2125

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Fix stacklevel in _CoroGuard's warning #2125

merged 1 commit into from
Jul 25, 2017

Conversation

hynek
Copy link
Contributor

@hynek hynek commented Jul 24, 2017

What do these changes do?

_CoroGuard’s warnings point to the user's code now.

Are there changes in behavior for the user?

They get useful warnings now.

Related issue number

Fixes #2106.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • [n/a] Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@hynek
Copy link
Contributor Author

hynek commented Jul 24, 2017

(Travis failures look very much unrelated.)

@asvetlov asvetlov merged commit b54f2e9 into aio-libs:master Jul 25, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings should provide a stacklevel
2 participants