Implement history for ClientResponseError. #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientResponseError will contain history from ClientResponse. Implememnts: #1741
History type is tuple
fafhrd91
reviewed
Mar 22, 2017
aiohttp/client_exceptions.py
Outdated
| @@ -25,11 +25,13 @@ class ClientResponseError(ClientError): | |||
| :param request_info: instance of RequestInfo | |||
| """ | |||
|
|
|||
| def __init__(self, request_info, *, code=0, message='', headers=None): | |||
| def __init__(self, request_info, *, code=0, message='', headers=None, | |||
| history=None): | |||
There was a problem hiding this comment.
let's make it required. we always pass history.
|
great! thanks. |
|
I have code-style question: no type-hints - it's project code-style, or it's allowed hinting with py3.3 backward compatibility? |
|
we started before type-hinting, we need to support py3.4 if you want to use type-hinting, make another PR |
|
Do you want me to wait with merge of this pr? |
|
No, it will be sepsrate issueId.
ср, 22 мар. 2017 г., 21:35 Nikolay Kim <[email protected]>:
Do you want me to wait with merge of this pr?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APSmM0tDArrH52Qw1qykW5YnV553j5MLks5roWnagaJpZM4Mlgfh>
.
--
Best regards, Alexey Stepanov.
|
|
Ok, good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
ClientResponseError will contain history from ClientResponse.
Are there changes in behavior for the user?
User can extract redirect history from exception and use it for error investigation purposes.
Related issue number
#1741