Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy fix #1421

Merged
merged 4 commits into from
Nov 24, 2016
Merged

Proxy fix #1421

merged 4 commits into from
Nov 24, 2016

Conversation

kserhii
Copy link
Contributor

@kserhii kserhii commented Nov 23, 2016

What do these changes do?

  • Adds functional proxy tests (proxy_test_server created)
  • Fixes client proxy bugs: target path and proxy host header with port

Are there changes in behavior for the user?

HTTPS proxy connection has been fixed.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@AraHaan
Copy link
Contributor

AraHaan commented Nov 23, 2016

Please resolve the conflicts.

@codecov-io
Copy link

codecov-io commented Nov 23, 2016

Current coverage is 98.91% (diff: 100%)

Merging #1421 into master will increase coverage by 0.02%

@@             master      #1421   diff @@
==========================================
  Files            30         30          
  Lines          6930       6932     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       1148       1149     +1   
==========================================
+ Hits           6853       6857     +4   
+ Misses           33         32     -1   
+ Partials         44         43     -1   

Powered by Codecov. Last update 517a38e...6cf2caa

@asvetlov
Copy link
Member

I like the PR.
It doesn't check by real proxy server but it's better than current solution.
Also I like changes in aiohttp code itself.

@asvetlov asvetlov merged commit deb0ec8 into aio-libs:master Nov 24, 2016
@asvetlov asvetlov mentioned this pull request Nov 24, 2016
5 tasks
@kserhii
Copy link
Contributor Author

kserhii commented Nov 24, 2016

Thanks a lot :)

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants