update regex in AccessLogger to accept underscore #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Unit Tests
Current coverage is 98.28% (diff: 100%)@@ master #1226 diff @@
==========================================
Files 29 29
Lines 6485 6485
Methods 0 0
Messages 0 0
Branches 1087 1087
==========================================
Hits 6374 6374
Misses 59 59
Partials 52 52
|
popravich
reviewed
Sep 29, 2016
| @@ -269,7 +269,7 @@ class AccessLogger: | |||
| """ | |||
|
|
|||
| LOG_FORMAT = '%a %l %u %t "%r" %s %b "%{Referrer}i" "%{User-Agent}i"' | |||
| FORMAT_RE = re.compile(r'%(\{([A-Za-z\-]+)\}([ioe])|[atPrsbOD]|Tf?)') | |||
| FORMAT_RE = re.compile(r'%(\{([A-Za-z\-_]+)\}([ioe])|[atPrsbOD]|Tf?)') | |||
There was a problem hiding this comment.
maybe numbers should be accepted as well?
There was a problem hiding this comment.
Not sure should we split header rules and environment variable
There was a problem hiding this comment.
updated to accept numbers, not sure about your last comment though
asvetlov
requested changes
Sep 29, 2016
| @@ -26,7 +26,7 @@ CHANGES | |||
| 1.0.3 (XXXX-XX-XX) | |||
| ------------------ | |||
|
|
|||
| - | |||
| - Modify regex in AccessLogger to accept underscore #1225 | |||
There was a problem hiding this comment.
Should be in 1.1.0 section unless you make a PR against 1.0 branch.
There was a problem hiding this comment.
Thanks for pointing this out, updated
esaezgil
force-pushed
the
issue_1225_update_regex
branch
from
f6037bf to
8f55e61
Compare
|
I am already in CONTRIBUTORS.txt from a previous contribution :) |
update unit tests
esaezgil
force-pushed
the
issue_1225_update_regex
branch
from
8f55e61 to
4cd214b
Compare
asvetlov
approved these changes
Sep 29, 2016
asvetlov
approved these changes
Sep 29, 2016
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Update regex in AccessLogger to accept underscore, update Unit Tests
Are there changes in behavior for the user?
no
Related issue number
#1225
Checklist
CONTRIBUTORS.txtCHANGES.rst#isuue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.update Unit Tests