Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to log certain environment variables in access log #1225

Closed
VladV opened this issue Sep 29, 2016 · 4 comments
Closed

Unable to log certain environment variables in access log #1225

VladV opened this issue Sep 29, 2016 · 4 comments
Labels
bug good first issue Good for newcomers outdated server

Comments

@VladV
Copy link

VladV commented Sep 29, 2016

%{FOO}e format doesn't accept underscores, so variables like SERVER_SOFTWARE cannot be included in the log.
Tested on 0.21.6, probably applies to the latest version as well.
@asvetlov
Copy link
Member

Regex from https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/helpers.py#L272 should accept underscore.
The patch is easy.
Any volunteers?

@esaezgil
Copy link
Contributor

I will address this :)

@esaezgil esaezgil mentioned this issue Sep 29, 2016
Merged
5 tasks
@asvetlov
Copy link
Member

Fixed by @1226

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue Good for newcomers outdated server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VladV @asvetlov @esaezgil