Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects for HEAD requests. #1147

Merged
merged 1 commit into from
Sep 10, 2016
Merged

Conversation

catlee
Copy link
Contributor

@catlee catlee commented Sep 9, 2016

What do these changes do?

Fixes redirects for HEAD requests

Are there changes in behavior for the user?

HEAD requests that are redirected will result in HEAD requests to the redirected URLs instead of GET requsets.

Related issue number

#1146

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Fixes: #1146

@codecov-io
Copy link

codecov-io commented Sep 9, 2016

Current coverage is 98.28% (diff: 100%)

Merging #1147 into master will not change coverage

@@             master      #1147   diff @@
==========================================
  Files            28         28          
  Lines          6489       6489          
  Methods           0          0          
  Messages          0          0          
  Branches       1087       1087          
==========================================
  Hits           6378       6378          
  Misses           61         61          
  Partials         50         50          

Powered by Codecov. Last update b705875...baaf9d3

@asvetlov asvetlov merged commit 118826c into aio-libs:master Sep 10, 2016
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects for HEAD requests should use HEAD
3 participants