Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10154/3f07b1a3 backport][3.12] Update StreamResponse.write annotation for strict-bytes #10158

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 11, 2024

This is a backport of PR #10154 as merged into master (3f07b1a).

What do these changes do?

Mypy will add a --strict-bytes flag. python/mypy#18263

With that bytearray and memoryview are no longer subclasses of bytes and must be listed explicitly instead if they are supported.

Are there changes in behavior for the user?

--

Related issue number

--

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

## What do these changes do?
Mypy will add a `--strict-bytes` flag.
python/mypy#18263

With that `bytearray` and `memoryview` are no longer subclasses of
`bytes` and must be listed explicitly instead if they are supported.

## Are there changes in behavior for the user?
--

## Related issue number
--

## Checklist

- [ ] I think the code is well written
- [ ] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [ ] Add a new news fragment into the `CHANGES/` folder
  * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`)
  * if you don't have an issue number, change it to the pull request
    number after creating the PR
    * `.bugfix`: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    * `.feature`: A new behavior, public APIs. That sort of stuff.
    * `.deprecation`: A declaration of future API removals and breaking
      changes in behavior.
    * `.breaking`: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    * `.doc`: Notable updates to the documentation structure or build
      process.
    * `.packaging`: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    * `.contrib`: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    * `.misc`: Changes that are hard to assign to any of the above
      categories.
  * Make sure to use full sentences with correct case and punctuation,
    for example:
    ```rst
    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.
    ```

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

---------

Co-authored-by: J. Nick Koston <[email protected]>
(cherry picked from commit 3f07b1a)
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #10158 will not alter performance

Comparing patchback/backports/3.12/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154 (a31cc46) with 3.12 (51cdda8)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (51cdda8) to head (a31cc46).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10158      +/-   ##
==========================================
+ Coverage   97.71%   98.06%   +0.34%     
==========================================
  Files         123      123              
  Lines       37139    37139              
  Branches     4468     4468              
==========================================
+ Hits        36291    36419     +128     
+ Misses        661      542     -119     
+ Partials      187      178       -9     
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+0.33%) ⬆️
OS-Linux 97.66% <100.00%> (+0.39%) ⬆️
OS-Windows 94.57% <100.00%> (?)
OS-macOS 96.77% <100.00%> (ø)
Py-3.10.11 96.62% <100.00%> (+0.28%) ⬆️
Py-3.10.15 97.21% <100.00%> (+0.23%) ⬆️
Py-3.11.10 97.23% <100.00%> (+0.18%) ⬆️
Py-3.11.9 96.70% <100.00%> (+0.29%) ⬆️
Py-3.12.7 97.71% <100.00%> (?)
Py-3.13.0 96.55% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 97.67% <100.00%> (?)
Py-3.9.13 96.55% <100.00%> (+0.28%) ⬆️
Py-3.9.20 97.13% <100.00%> (?)
Py-pypy7.3.16 96.70% <100.00%> (?)
VM-macos 96.77% <100.00%> (ø)
VM-ubuntu 97.66% <100.00%> (+0.39%) ⬆️
VM-windows 94.57% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit 5d9d830 into 3.12 Dec 11, 2024
36 checks passed
@asvetlov asvetlov deleted the patchback/backports/3.12/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154 branch December 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants