Fix deprecated calls to guess_type for paths with Python 3.13
#10102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been a call to guess_file_type as guess_type expects a URL and guess_file_type expects a path
bdraco
added
backport-3.11
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10102 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 122 122
Lines 36904 36912 +8
Branches 4400 4402 +2
=======================================
+ Hits 36447 36455 +8
Misses 311 311
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
changed the title
bdraco
changed the title
guess_type in FileResponse for Python 3.13
CodSpeed Performance ReportMerging #10102 will not alter performanceComparing Summary
|
bdraco
changed the title
guess_type in FileResponse for Python 3.13guess_type for paths with Python 3.13
bdraco
changed the title
guess_type for paths with Python 3.13guess_type for paths with Python 3.13
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
commented
Dec 4, 2024
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10103 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
(cherry picked from commit 7557b03)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10104 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
(cherry picked from commit 7557b03)
bdraco
added a commit
that referenced
this pull request
Dec 4, 2024
…pe` for paths with Python 3.13 (#10103) Co-authored-by: J. Nick Koston <[email protected]>
bdraco
added a commit
that referenced
this pull request
Dec 4, 2024
…pe` for paths with Python 3.13 (#10104) Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
https://docs.python.org/3/library/mimetypes.html#mimetypes.guess_type
These should have been changed to
guess_file_typeon Python 3.13 asguess_typeexpects a URL andguess_file_typeexpects a path. Its a soft deprecation so they still work but that may change in the future.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no