Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create connections with verify_ssl=False on OSX #583

Closed
dudecc opened this issue Oct 22, 2015 · 2 comments
Closed

Cannot create connections with verify_ssl=False on OSX #583

dudecc opened this issue Oct 22, 2015 · 2 comments
Labels
outdated

Comments

@dudecc
Copy link
Contributor

dudecc commented Oct 22, 2015

I found this issue on my laptop which is still running OSX 10.8, but also on someone else's laptop running 10.9.

The issue seems to be this line, where we assume unconditionally that ssl has the OP_NO_COMPRESSION attribute whenever we create a connection with verify_ssl=False. But according to the ssl docs, this attribute only exists if the version of libssl backing the ssl module is at least 1.0.0. But on both of these OSX machines the _ssl extension module is linking in /usr/lib/libssl.0.9.8.dylib, and consequently ssl.OP_NO_COMPRESSION does not exist.

There was already a workaround for this in the codebase fairly recently, but it got taken out when python3.3 support was dropped in this commit. (For the record I am seeing this problem on 3.4.3.)
dudecc added a commit to dudecc/aiohttp that referenced this issue Oct 22, 2015
@dudecc
Re add support for OpenSSL < 1.0.0
b5f92f9 
This reverts part of commit 08cedb8,
which appears to have accidentally removed openssl < 1.0.0 compatibility when
removing python3.3 compatibility.  See aio-libs#583
@dudecc dudecc mentioned this issue Oct 22, 2015
Merged
@asvetlov
Copy link
Member

Fixed by 0.18.2 bugfix

asvetlov pushed a commit that referenced this issue Oct 22, 2015
@dudecc @asvetlov
Re add support for OpenSSL < 1.0.0
1c3b09e 
This reverts part of commit 08cedb8,
which appears to have accidentally removed openssl < 1.0.0 compatibility when
removing python3.3 compatibility.  See #583
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @dudecc