Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] Adjust test job timeouts in GitHub Actions CI/CD jobs #5389

Closed
webknjaz opened this issue Jan 8, 2021 · 2 comments · Fixed by #5408
Closed

[maintenance] Adjust test job timeouts in GitHub Actions CI/CD jobs #5389

webknjaz opened this issue Jan 8, 2021 · 2 comments · Fixed by #5408

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 8, 2021

🐞 Describe the bug

The CI doesn't complete currently because the test jobs are capped to run under 15 minutes and they now get killed on timeout. I believe this is called by the new pip resolver doing backtracking which is rather time-consuming.

💡 To Reproduce

It's visible in any recent CI build.

💡 Expected behavior

The jobs should complete. Carefully bumping the timeout in the workflow file should be enough.

📋 Logs/tracebacks

Example: https://github.com/aio-libs/aiohttp/runs/1669008218?check_suite_focus=true

📋 Your version of the Python

N/A

📋 Your version of the aiohttp/yarl/multidict distributions

repo master

📋 Additional context

N/A

@greshilov
Copy link
Contributor

greshilov commented Jan 9, 2021

Increased timeout will not solve the problem completely, I guess. Stricter requirements.txt could help though.

@webknjaz
Copy link
Member Author

webknjaz commented Jan 9, 2021

I think increasing the timeout should be enough to get it to run completely for the first time and then many things will probably get picked up from cache. One of the problems there is that when pip has to download many package versions, it makes the backtracking substantially slower when those packages don't have wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants