Integrate trustme for testing TLS support against a "real CA" with "real" certificates #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
testing/trustme-integration
branch
3 times, most recently
from
5ff0f5e to
50417f1
Compare
webknjaz
force-pushed
the
testing/trustme-integration
branch
from
50417f1 to
8cbb8c4
Compare
asvetlov
pushed a commit
that referenced
this pull request
Jan 5, 2019
Also: * Use real TLS context where it's disabled in tests * Add a change note about trustme integration Closes #3487. (cherry picked from commit c180800) Co-authored-by: Sviatoslav Sydorenko <[email protected]>
5 tasks
asvetlov
added a commit
that referenced
this pull request
Jan 5, 2019
Also: * Use real TLS context where it's disabled in tests * Add a change note about trustme integration Closes #3487. (cherry picked from commit c180800) Co-authored-by: Sviatoslav Sydorenko <[email protected]>
|
Trustme should be added to |
dotlambda
pushed a commit
to dotlambda/aiohttp
that referenced
this pull request
Jan 10, 2019
It is required since aio-libs#3487.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
Not really
Related issue number
I mentioned it @ #3180 (comment) if that counts
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.