web.Response converts headers to uppercase

[isaacl]

HTTP headers are technically case insensitive but it might be nice to preserve input case for readability.

[kxepal]

Good point. I would say more: send headers titled instead of uppercased like they are defined in spec (Content-Type etc.). Turning them all into upper case looks as an ugly hack to simplify key lookup and further comparison.

[asvetlov]

Hmm. Nice to have, but requires deep multidict refactoring.
Please don't start to do it right now: I'm working on accelerated version of multidicts (optional, of course): https://github.com/KeepSafe/aiohttp/blob/cytonize_multidicts/aiohttp/_multidict.pyx

[kxepal]

@asvetlov looks cool, but does multidict is really needs in such optimization? I always thought that routing is far much more good candidate for that...anyway, look forward for your work on this!

[asvetlov]

I did profiling.
Router is called once per request, regexps are fast.
But on every requests we have many reads and writes for headers (low-level server also operates with multidicts, BTW).

[isaacl]

As @kxepal suggested, we could default to title case instead of upper case. That would avoid changing the actual storage structures, and can be done when formatting the response.

[asvetlov]

@isaacl it requires data structure changing.

[fafhrd91]

-1 for camel case. I like capitalized header

On Thursday, January 8, 2015, Andrew Svetlov [email protected]
wrote:

@isaacl https://github.com/isaacl it requires data structure changing.

—
Reply to this email directly or view it on GitHub
#223 (comment).

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.